On 12/5/23 20:58, Joe Perches wrote:
On Tue, 2023-12-05 at 20:02 +0200, Nikolai Kondrashov wrote:
Require the entry values to not contain the '@' character, so they could
be distinguished from emails (always) output by get_maintainer.pl.
Why is this useful?
Why the need to distinguish?
This is because get_maintainer.pl seems to insist on *always* outputting
emails. I guess that was its sole original purpose, and it stuck to it? It
kinda makes sense to me, especially given the name of the script, but at the
same time, as a consequence you can't query *only* the tests (or anything but
emails, really).
Therefore we have to be able to somehow filter out the emails from the
get_maintainer.pl output, to get only the tests. Email addresses *have* to
have the '@' character (seems to be the only reliable thing about them :D), so
naturally I chose that as the way to distinguish them from the tests.
It's ugly, but considering the get_maintainer.pl legacy, it's good enough.
I don't mind changing get_maintainer.pl, though, to stop it from outputting
emails (e.g. given an option), if that works for everyone involved.
Nick
