Re: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/1/23 07:24, Song Yoong Siang wrote:
This series expands XDP TX metadata framework to include ETF HW offload.

Changes since v1:
- rename Time-Based Scheduling (TBS) to Earliest TxTime First (ETF)
- rename launch-time to txtime


I strongly disagree with this renaming (sorry to disagree with Willem).

The i210 and i225 chips call this LaunchTime in their programmers datasheets, and even in the driver code[1].

Using this "txtime" name in the code is also confusing, because how can people reading the code know the difference between:
 - tmo_request_timestamp and tmo_request_txtime


[1] https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org

v1: https://patchwork.kernel.org/project/netdevbpf/cover/20231130162028.852006-1-yoong.siang.song@xxxxxxxxx/

Song Yoong Siang (3):
   xsk: add ETF support to XDP Tx metadata
   net: stmmac: Add txtime support to XDP ZC
   selftests/bpf: Add txtime to xdp_hw_metadata

  Documentation/netlink/specs/netdev.yaml        |  4 ++++
  Documentation/networking/xsk-tx-metadata.rst   |  5 +++++
  drivers/net/ethernet/stmicro/stmmac/stmmac.h   |  2 ++
  .../net/ethernet/stmicro/stmmac/stmmac_main.c  | 13 +++++++++++++
  include/net/xdp_sock.h                         |  9 +++++++++
  include/net/xdp_sock_drv.h                     |  1 +
  include/uapi/linux/if_xdp.h                    |  9 +++++++++
  include/uapi/linux/netdev.h                    |  3 +++
  net/core/netdev-genl.c                         |  2 ++
  net/xdp/xsk.c                                  |  3 +++
  tools/include/uapi/linux/if_xdp.h              |  9 +++++++++
  tools/include/uapi/linux/netdev.h              |  3 +++
  tools/net/ynl/generated/netdev-user.c          |  1 +
  tools/testing/selftests/bpf/xdp_hw_metadata.c  | 18 +++++++++++++++++-
  14 files changed, 81 insertions(+), 1 deletion(-)





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux