On Mon, 30 Oct 2023 at 18:47, Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx> wrote: > > Check the stream pointer passed to string_stream_destroy() for > IS_ERR_OR_NULL() instead of only NULL. > > Whatever alloc_string_stream() returns should be safe to pass > to string_stream_destroy(), and that will be an ERR_PTR. > > It's obviously good practise and generally helpful to also check > for NULL pointers so that client cleanup code can call > string_stream_destroy() unconditionally - which could include > pointers that have never been set to anything and so are NULL. > > Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx> > --- Yeah, this makes sense, and let's support NULL as well. Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Cheers, -- David
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
