Hangbin Liu <liuhangbin@xxxxxxxxx> writes:
> On Fri, Nov 24, 2023 at 03:05:18PM +0100, Petr Machata wrote:
>>
>> Hangbin Liu <liuhangbin@xxxxxxxxx> writes:
>>
>> > +# Helpers
>> > +busywait()
>> > +{
>> > + local timeout=$1; shift
>> > +
>> > + local start_time="$(date -u +%s%3N)"
>> > + while true
>> > + do
>> > + local out
>> > + out=$($@)
>> > + local ret=$?
>> > + if ((!ret)); then
>> > + echo -n "$out"
>> > + return 0
>> > + fi
>> > +
>> > + local current_time="$(date -u +%s%3N)"
>> > + if ((current_time - start_time > timeout)); then
>> > + echo -n "$out"
>> > + return 1
>> > + fi
>> > + done
>> > +}
>>
>> This is lifted from forwarding/lib.sh, right? Would it make sense to
>
> Yes.
>
>> just source this new file from forwarding/lib.sh instead of copying
>
> Do you mean let net/forwarding/lib.sh source net.lib, and let other net
> tests source the net/forwarding/lib.sh?
>
> Or move the busywait() function from net/forwarding/lib.sh to net.lib.
> Then let net/forwarding/lib.sh source net.lib?
This.
>> stuff around? I imagine there will eventually be more commonality, and
>> when that pops up, we can just shuffle the forwarding code to
>> net/lib.sh.
>
> Yes, make sense.
>
> Thanks
> Hangbin
