Re: [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Daniel Xu <dxu@xxxxxxxxx>
Subject: Re: [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()
From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>
Date: Wed, 22 Nov 2023 15:28:16 -0800
Cc: John Fastabend <john.fastabend@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Steffen Klassert <steffen.klassert@xxxxxxxxxxx>, antony.antony@xxxxxxxxxxx, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Network Development <netdev@xxxxxxxxxxxxxxx>, devel@xxxxxxxxxxxxxxx
In-reply-to: <84111ba0ea652a7013df520c151d40d400401e9c.1700676682.git.dxu@dxuuu.xyz>

On Wed, Nov 22, 2023 at 10:21 AM Daniel Xu <dxu@xxxxxxxxx> wrote:
>
> +
> +       bpf_printk("replay-window %d\n", x->replay_esn->replay_window);

Pls no printk in tests. Find a different way to validate.

Follow-Ups:
- Re: [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()
  - From: Daniel Xu

References:
- [PATCH ipsec-next v1 0/7] Add bpf_xdp_get_xfrm_state() kfunc
  - From: Daniel Xu
- [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()
  - From: Daniel Xu

Prev by Date: [PATCH 1/3] tools/nolibc: drop custom definition of struct rusage
Next by Date: Re: [PATCH] kselftests: add per_test_log support
Previous by thread: [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()
Next by thread: Re: [PATCH ipsec-next v1 7/7] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]