From: zhujun2 <zhujun2@xxxxxxxxxxxxxxxxxxxx> The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 <zhujun2@xxxxxxxxxxxxxxxxxxxx> --- Hi Dan Carpenter I believe that the Linux kernel code is sacred and should strictly adhere to C code conventions thanks, [Zhu Jun] tools/testing/selftests/media_tests/media_device_open.c | 2 ++ tools/testing/selftests/media_tests/media_device_test.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/testing/selftests/media_tests/media_device_open.c b/tools/testing/selftests/media_tests/media_device_open.c index 93183a37b133..ae263eb78a2c 100644 --- a/tools/testing/selftests/media_tests/media_device_open.c +++ b/tools/testing/selftests/media_tests/media_device_open.c @@ -79,4 +79,6 @@ int main(int argc, char **argv) else printf("Media device model %s driver %s\n", mdi.model, mdi.driver); + + close(fd); } diff --git a/tools/testing/selftests/media_tests/media_device_test.c b/tools/testing/selftests/media_tests/media_device_test.c index 4b9953359e40..65888ce5c89f 100644 --- a/tools/testing/selftests/media_tests/media_device_test.c +++ b/tools/testing/selftests/media_tests/media_device_test.c @@ -100,4 +100,6 @@ int main(int argc, char **argv) sleep(10); count--; } + + close(fd); } -- 2.17.1