On 2023-11-14 04:38, zhujun2 wrote:
The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading
Fixing resource leaks for one-off test cases (processes execute and then immediately exit) seems to be something that would fit in the definition of "trivial", so I would advise to perhaps send those patches to kernel-janitors@xxxxxxxxxxxxxxx ? [...]
+ + close(fd);
These added calls to close(2) miss handling of possible close errors (check return value and use errno to print an error). Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com
