Re: [PATCH] Kunit to check the longest symbol length

[Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>]

On 11/5/23 15:40, Sergio González Collado wrote:
> [...]
> diff --git a/lib/Makefile b/lib/Makefile
> index 740109b6e2c8..82ac084b6bc6 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -402,6 +402,7 @@ obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
>   obj-$(CONFIG_STRCAT_KUNIT_TEST) += strcat_kunit.o
>   obj-$(CONFIG_STRSCPY_KUNIT_TEST) += strscpy_kunit.o
>   obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
> +obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o
>   
>   obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o
>   

This test is triggering `-Wmissing-prototypes`, so you might have to
either add the prototypes or change the hunk to this.

diff --git a/lib/Makefile b/lib/Makefile
index 740109b6e2c8..b9d2577fbbe1 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -402,6 +402,8 @@ obj-$(CONFIG_FORTIFY_KUNIT_TEST) += fortify_kunit.o
 obj-$(CONFIG_STRCAT_KUNIT_TEST) += strcat_kunit.o
 obj-$(CONFIG_STRSCPY_KUNIT_TEST) += strscpy_kunit.o
 obj-$(CONFIG_SIPHASH_KUNIT_TEST) += siphash_kunit.o
+obj-$(CONFIG_LONGEST_SYM_KUNIT_TEST) += longest_symbol_kunit.o
+CFLAGS_longest_symbol_kunit.o += $(call cc-disable-warning, missing-prototypes)
 
 obj-$(CONFIG_GENERIC_LIB_DEVMEM_IS_ALLOWED) += devmem_is_allowed.o
 

> diff --git a/lib/longest_symbol_kunit.c b/lib/longest_symbol_kunit.c
> new file mode 100644
> index 000000000000..6282fbb7e991
> --- /dev/null
> +++ b/lib/longest_symbol_kunit.c
> [...]
> +
> +noinline int LONGEST_SYM_NAME(void)
> +{
> +	return RETURN_LONGEST_SYM;
> +}
> +
> +noinline int LONGEST_SYM_NAME_PLUS1(void)
> +{
> +	return RETURN_LONGEST_SYM_PLUS1;
> +}

arch/x86/tools/insn_decoder_test.c has a buffer size of 256 that might be
too short for these symbols, you might have to increase it for it to work.

> [...]