Oct 22, 2023 11:37:05 Willy Tarreau <w@xxxxxx>: > On Tue, Oct 10, 2023 at 02:34:00PM +0200, Thomas Weißschuh wrote: >> This new target generates a .config if none exists yet. >> >> Also drop the defconfig target with its hidden call to 'mrproper' which >> is fairly invasive. >> If users want to overwrite their kernel existing kernel configuration >> they can do so easily from the toplevel directory. > > Hmmm I'm not sure about that one, I pretty much remember seeing failing > arm64 builds when mrproper and prepare were missing. > > I would argue that someone starting "make defconfig" does expect the > config to be dropped, hence mrproper to be called as well. > > What specific issue did you face with it ? Maybe we can restrict it to > only a few cases ? It was mostly a quality improvement for my testscript, where the config was generated automatically. And then I dropped the combined defconfig target because it seemed unnecessary. Let's drop this patch. Thomas
