Re: [PATCH] selftests/clone3: Skip new time namespace test when unsupported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/20/2023 07:35 AM, Andrew Morton wrote:
On Fri, 20 Oct 2023 00:08:12 +0100 Mark Brown <broonie@xxxxxxxxxx> wrote:

Use a filter function to skip the time namespace test on systems with
!CONFIG_TIME_NS. This reworks a fix originally done by Tiezhu Yang prior
to the refactoring in 34dce23f7e40 ("selftests/clone3: Report descriptive
test names"). The changelog from their fix explains the issue very clearly:

I was about to send Tiezhu Yang's fix to Linus.   I'll rebase mm-hotfixes-stable
to drop that patch, so you own it now!

Please note that your version lacks an explicit cc:stable, but I suppose the
stablebots will scoop it up anyway.

Original-fix-from: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>

"Original-fix-from" isn't a thing.  In fact it seems to be the first
time this has been used.  Grepping for  "Original-.*:" shows
all sorts of innovations, including "Based-on-the-original-screenplay-by:".

I guess Documentation/process/submitting-patches.rst and checkpatch
lost this fight a long time ago.


Thank you all.

If it is possible, I think it is better to rebase linux-kselftest next
to do the following things sequentially.

(1) Apply patch "selftests/clone3: Fix broken test under !CONFIG_TIME_NS"
which is sent on 11 Jul 2023.

https://lore.kernel.org/linux-kselftest/1689066814-13295-1-git-send-email-yangtiezhu@xxxxxxxxxxx/

(2) Squash the changes in patch "selftests/clone3: Skip new time namespace test when unsupported"

https://lore.kernel.org/linux-kselftest/20231020-kselftest-clone3-time-ns-v1-1-31a17e072a05@xxxxxxxxxx/

into patch "selftests/clone3: Report descriptive test names", and then apply it.

https://lore.kernel.org/linux-kselftest/20231018-kselftest-clone3-output-v1-1-12b7c50ea2cf@xxxxxxxxxx/

This can make the log more clear. Anyway, I am fine with either way.

Thanks,
Tiezhu




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux