On Thu, Oct 12, 2023 at 05:13:59PM +0800, Yi Liu wrote: > > > @@ -241,6 +245,21 @@ struct iommu_user_data { > > > size_t len; > > > }; > > > > > > +/** > > > + * struct iommu_user_data_array - iommu driver specific user space data array > > > + * @uptr: Pointer to the user buffer array for copy_from_user() > > > + * @entry_len: The fixed-width length of a entry in the array, in bytes > > > + * @entry_num: The number of total entries in the array > > > + * > > > + * A array having a @entry_num number of @entry_len sized entries, each entry is > > > + * user space data, i.e. an uAPI that is defined in include/uapi/linux/iommufd.h > > > + */ > > > +struct iommu_user_data_array { > > > + void __user *uptr; > > > + size_t entry_len; > > > + int entry_num; > > > +}; > > > > Ditto about iommu-driver.h for most of this stuff > > ack. FYI, I aligned with Jason in another conversation that we can defer this iommu-driver.h thing since there's no more need to include the previous uapi header in iommu.h Thanks Nic