On Fri, Oct 13, 2023 at 12:33:13PM +0800, Yi Liu wrote: > not really. Below the users of the struct iommu_user_data in my current > iommufd_nesting branch. Only the domain_alloc_user op has type as there > can be multiple vendor specific alloc data types. Basically, I'm ok to > make the change you suggested, just not sure if it is good to add type > as it is only needed by one path. I don't think we should ever have an opaque data blob without a type tag.. Jason