On Wed, 27 Sept 2023 at 17:04, Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote: > > The test_cases is not freed in kunit_free_suite_set(). > > And the copy pointer may be moved in kunit_filter_suites(). > > The filtered_suite and filtered_suite->test_cases allocated in the last > kunit_filter_attr_tests() in last inner for loop may be leaked if > kunit_filter_suites() fails. > > If kunit_filter_suites() succeeds, not only copy but also filtered_suite > and filtered_suite->test_cases should be freed. > > Changes in v4: > - Make free_suite_set() take a void * for the 4th patch. > - Add Suggested-by and Reviewed-by. > - Correct the fix tag. > > Changes in v3: > - Update the kfree_at_end() to use kunit_free_suite_set() for 4th patch. > - Update the commit message for the 4th patch. > > Changes in v2: > - Add Reviewed-by. > - Add the memory leak backtrace for the 4th patch. > - Remove the unused func kernel test robot noticed for the 4th patch. > - Update the commit message for the 4th patch. > > Jinjie Ruan (4): > kunit: Fix missed memory release in kunit_free_suite_set() > kunit: Fix the wrong kfree of copy for kunit_filter_suites() > kunit: Fix possible memory leak in kunit_filter_suites() > kunit: test: Fix the possible memory leak in executor_test > > lib/kunit/executor.c | 23 +++++++++++++++++------ > lib/kunit/executor_test.c | 36 ++++++++++++++++++++++-------------- > 2 files changed, 39 insertions(+), 20 deletions(-) > > -- Thanks. This is all looking good to me. The whole series is (still): Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Cheers, -- David
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
