Hi Sima, (For some reason, it looks like your mailer sets up the headers to reply to every recipient but you) On Tue, Sep 12, 2023 at 09:36:12AM +0200, Daniel Vetter wrote: > On Mon, Sep 11, 2023 at 11:51:06AM +0200, Maxime Ripard wrote: > > Kunit recently gained a speed attribute that allows to filter out slow > > tests. A slow test is defined in the documentation as a test taking more > > than a second to execute. > > > > Let's flag the few tests that are doing so on my machine when running: > > > > ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \ > > --cross_compile aarch64-linux-gnu- --arch arm64 > > > > Suggested-by: David Gow <davidgow@xxxxxxxxxx> > > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx> > > Ugh ... not a fan. > > igt has a really bad habit of making disastrously combinatorial tests with > impossible runtimes, and then just filtering these out so it's still fast. > > Maybe some stress tests for overall system make sense like this, but > absolutely not for unit tests. I agree, I didn't want to reduce testing though. > And I did spot check some of these, they're just combinatorial > explosions with large repetition counts and some fun stuff like going > through prime numbers because surely that's a good idea. > > Imo delete them all, and if that causes a real gap in coverage, ask > the authors to write some actual good unit tests for these corner > cases. Ack, I will send a patch doing so. Thanks! Maxime
Attachment:
signature.asc
Description: PGP signature
