On Fri, Sep 08, 2023 at 09:27:12PM -0400, Steven Rostedt wrote: > On Sat, 9 Sep 2023 00:33:05 +0100 > Mark Brown <broonie@xxxxxxxxxx> wrote: > > > On Fri, Sep 08, 2023 at 08:19:16PM +0000, Beau Belgrave wrote: > > > > > Add common methods to detect if tracefs and user_events is enabled. If > > > either is not enabled skip the test. If tracefs is enabled, but is not > > > mounted, mount tracefs and fail if there were any errors. Fail if not > > > run as root. > > > > This will leave tracefs mounted if it was not already mounted which is a > > change to the system configuration. While that may happen if things go > > wrong during a test we should probably avoid actively doing this and > > either only skip or try to umount at the end of the test if we mounted > > ourselves. > > LOL! Beau just asked me yesterday if anyone would care if the test mounted > tracefs and left it mounted. I told him "no" as ftracetest in the selftests > already do that. > > I guess I was wrong and some people do care ;-) > > -- Steve It looks like this change got applied [1] to the fixes branch of linux-kselftest. I can either send a V3 with this addressed or build a patch based upon the fixes branch on top of this one to address it. Which way do you all prefer? Thanks, -Beau 1. https://git.kernel.org/shuah/linux-kselftest/c/a06023a8f78d
