Hi Ilpo,
On 8/31/2023 4:08 AM, Ilpo Järvinen wrote:
> Benchmark argument is handled by custom argument parsing code which is
> more complicated than it needs to be.
>
> Process benchmark argument within the normal getopt() handling and drop
> unnecessary ben_ind and has_ben variables. When -b is given, terminate
> the argument processing as -b consumes all remaining arguments.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Tested-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> ---
> .../testing/selftests/resctrl/resctrl_tests.c | 46 +++++++++----------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 48e5afb1530c..831d50a37d78 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -169,27 +169,34 @@ static void run_cat_test(int cpu_no, int no_of_bits)
>
> int main(int argc, char **argv)
> {
> - bool has_ben = false, mbm_test = true, mba_test = true, cmt_test = true;
> - int c, cpu_no = 1, argc_new = argc, i, no_of_bits = 0;
> - const char *benchmark_cmd[BENCHMARK_ARGS];
> - int ben_ind, tests = 0;
> + bool mbm_test = true, mba_test = true, cmt_test = true;
> + int c, cpu_no = 1, i, no_of_bits = 0;
> + const char *benchmark_cmd[BENCHMARK_ARGS] = {};
> char *span_str = NULL;
Could you please keep reverse fir ordering?
Reinette
