On Fri, Aug 18, 2023 at 11:38 AM Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> wrote: > > On Fri, Aug 18, 2023 at 10:05:00AM -0500, Rob Herring wrote: > > On Thu, Aug 17, 2023 at 6:36 PM Nícolas F. R. A. Prado > > <nfraprado@xxxxxxxxxxxxx> wrote: > [..] > > > tools/testing/selftests/Makefile | 1 + > > > tools/testing/selftests/dt/.gitignore | 1 + > > > tools/testing/selftests/dt/Makefile | 21 +++++ > > > > Please add this path to DT maintainers entry. > > OK. > > > > > > .../selftests/dt/compatible_ignore_list | 1 + > > > tools/testing/selftests/dt/ktap_helpers.sh | 57 +++++++++++++ > > > > As Mark said, looks common. > > Yes, I'll move it one folder up. > > > > [..] > > > --- /dev/null > > > +++ b/tools/testing/selftests/dt/.gitignore > > > @@ -0,0 +1 @@ > > > +compatible_list > > > > Not sure on the selftests, but is this enough that it gets cleaned? > > I've just double-checked that compatible_list does get removed with make clean. > Not because it is in this gitignore, but because it is listed in TEST_GEN_FILES > in the Makefile. > > > > [..] > > > --- /dev/null > > > +++ b/tools/testing/selftests/dt/test_unprobed_devices.sh > [..] > > > +PDT=/proc/device-tree/ > > > > This is considered the legacy path though we will probably never get > > rid of it. Use the sysfs path instead. > > The /sys/firmware/devicetree/* entry in > Documentation/ABI/testing/sysfs-firmware-ofw reads: > > Userspace must not use the /sys/firmware/devicetree/base > path directly, but instead should follow /proc/device-tree > symlink. It is possible that the absolute path will change > in the future, but the symlink is the stable ABI. > > So is this information outdated? No, my memory is just wrong... Rob