> -----Original Message----- > From: Ido Schimmel <idosch@xxxxxxxxxx> > Sent: Tuesday, 22 August 2023 20:57 > To: Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; David S . Miller > <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub > Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; David Ahern > <dsahern@xxxxxxxxxx>; Ido Schimmel <idosch@xxxxxxxxxx>; Shuah Khan > <shuah@xxxxxxxxxx> > Subject: Re: [PATCH 3/3] selftests: forwarding: Add test for load-balancing > between multiple servers > > On Mon, Aug 21, 2023 at 07:36:47PM +0000, Sriram Yagnaraman wrote: > > Do you think it would be OK to drop this patch from the series for now? I can > come back with the selftest when I have something working correctly? > > There's a more direct way of testing it and that's by counting the number of > times the relevant FIB trace point was triggered. This script [1] does it for IPv4. > For IPv6 the equivalent trace point is called fib6:fib6_table_lookup. The script > can obviously be made nicer. > > Before the patches: > > # ./mp_repo.sh > 10020 > > After the patches: > > # ./mp_repo.sh > 65535 > > You can see that after the patches the trace point is triggered for every packet. > Sometimes it's a bit less. I assume because some events are lost. > > Another approach would be to tweak the current test so that $h1 and $rp1 are > configured in a similar fashion to veth0 and veth1. > Nice. Thanks a lot, I will send v2 with this approach.
