On Fri, Aug 18, 2023 at 01:54:21PM +0100, Mark Brown wrote: > On Thu, Aug 17, 2023 at 07:35:27PM -0400, Nícolas F. R. A. Prado wrote: > > > --- /dev/null > > +++ b/tools/testing/selftests/dt/ktap_helpers.sh > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +# > > +# Copyright (c) 2023 Collabora Ltd > > +# > > +# Helpers for outputting in KTAP format > > +# > > These look generic so could be at the top level kselftest directory in > case any other tests want to use them? Yes, they're generic. And sure, we can move it up. The tests using it will need to source it at run-time, so we can either update the kselftest Makefile to always copy this helper when installing, or each test's Makefile can make its own copy during build. > > The test itself looks good in so far as I can read shell. Thanks for the feedback! Thanks, Nícolas
