On Thu, 17 Aug 2023 09:02:33 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> Shuah,
>
> Can you take this in your tree?
Actually, hold off please.
>
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
>
> -- Steve
>
>
> On Thu, 17 Aug 2023 14:16:03 +0900
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:
>
> > On Thu, 17 Aug 2023 10:50:28 +0800
> > Yipeng Zou <zouyipeng@xxxxxxxxxx> wrote:
> >
> > > Fixes: d87b29179aa0 ("selftests: ftrace: Use md5sum to take less time of checking logs")
> > > Suggested-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> > > Signed-off-by: Yipeng Zou <zouyipeng@xxxxxxxxxx>
> > > ---
> > > .../ftrace/test.d/ftrace/func_traceonoff_triggers.tc | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> > > index aee22289536b..c5783999582d 100644
> > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> > > @@ -90,9 +90,9 @@ if [ $on != "0" ]; then
> > > fail "Tracing is not off"
> > > fi
> > >
> > > -csum1=`md5sum trace`
Yipeng, can you please add the comment here:
# Cannot rely on names being around as they are only cached, strip them
> > > +csum1=`cat trace | sed -e 's/^ *[^ ]*\(-[0-9][0-9]*\)/\1/' | md5sum`
-- Steve
> > > sleep $SLEEP_TIME
> > > -csum2=`md5sum trace`
> > > +csum2=`cat trace | sed -e 's/^ *[^ ]*\(-[0-9][0-9]*\)/\1/' | md5sum`
> > >
> > > if [ "$csum1" != "$csum2" ]; then
> > > fail "Tracing file is still changing"
> > > --
> > > 2.34.1
> > >
> >
> >
>
