On 8/7/23 11:15, Greg Kroah-Hartman wrote:
On Fri, Aug 04, 2023 at 07:00:18PM +0200, Mirsad Todorovac wrote:[ commit be37bed754ed90b2655382f93f9724b3c1aae847 upstream ] Dan Carpenter spotted that test_fw_config->reqs will be leaked if trigger_batched_requests_store() is called two or more times. The same appears with trigger_batched_requests_async_store(). This bug wasn't triggered by the tests, but observed by Dan's visual inspection of the code. The recommended workaround was to return -EBUSY if test_fw_config->reqs is already allocated. Fixes: c92316bf8e94 ("test_firmware: add batched firmware tests") Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Russ Weight <russell.h.weight@xxxxxxxxx> Cc: Tianfei Zhang <tianfei.zhang@xxxxxxxxx> Cc: Shuah Khan <shuah@xxxxxxxxxx> Cc: Colin Ian King <colin.i.king@xxxxxxxxx> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Cc: linux-kselftest@xxxxxxxxxxxxxxx Cc: stable@xxxxxxxxxxxxxxx # v4.14 Suggested-by: Dan Carpenter <error27@xxxxxxxxx> Suggested-by: Takashi Iwai <tiwai@xxxxxxx> Link: https://lore.kernel.org/r/20230509084746.48259-2-mirsad.todorovac@xxxxxxxxxxxx Signed-off-by: Mirsad Todorovac <mirsad.todorovac@xxxxxxxxxxxx> [ This fix is applied against the 4.14 stable branch. There are no changes to the ] [ fix in code when compared to the upstread, only the reformatting for backport. ]Thanks for all of these, now queued up.
No problem, I should have done it right the first time to reduce your load. I really believe that backporting bug fix patches is important because many systems cannot upgrade because of the legacy apps and hardware, to state the obvious. I know because we are in that group. :-) Kind regards, Mirsad Todorovac
