On Sun, Jul 30, 2023 at 12:54:45AM +0800, Zhangjin Wu wrote: > > Also I find it odd to use $(ARCH) here, I would have expected $(XARCH) > > since you probably want to distinguish ppc64 from ppc for example. > > > > Yes, we do, but the XARCH and ARCH mmapping patch is the 4th, will > update this to XARCH, this one is the 3th one, do we need to add this > one after the 4th one? OK indeed it's the 4th one that will modify this one then, no need to reorder. > > > > something like "make nolibctestconfig" to make an existing config ready for > > > > nolibc-test. > > > > > > Do you mean rename 'defconfig' to 'nolibctestconfig'? or something > > > nolibc-test-config: > > > > > > nolibc-test-config: > > > $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) mrproper $(DEFCONFIG) prepare > > > $(Q)$(srctree)/scripts/kconfig/merge_config.sh -O "$(srctree)" -m "$(srctree)/.config" $(foreach c,$(EXTRA_CONFIG),$(wildcard $(CURDIR)/configs/$c)) > > > $(Q)$(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROSS_COMPILE) KCONFIG_ALLCONFIG="$(srctree)/.config" allnoconfig > > > > > > It looks too long ;-) > > > > I think that as long as we don't claim to call topdir's makefile targets > > from this directory, we can reuse some similarly named targets which are > > documented in "make help" and are non-ambiguous. > > Seems 'nolibc-test-config' is really more meaningful than 'defconfig', especially > when we want to use tinyconfig through it? > > $ make nolibc-test-config DEFCONFIG=tinyconfig As a user, I'd ask "why not make tinyconfig" ? But see my other message, now I'm having strong doubts about the relevance of tinyconfig if it works as bad as you described it. Willy
