Hi, Thomas > > On 2023-07-19 05:10:48+0800, Zhangjin Wu wrote: > > Both syscall declarations and _start code definition are added for > > powerpc to nolibc. > > [...] > > > > Signed-off-by: Zhangjin Wu <falcon@xxxxxxxxxxx> > > --- > > tools/include/nolibc/arch-powerpc.h | 156 ++++++++++++++++++++++++++++ > > This also should be added to nolibc/arch.h. > Thanks, it should be. > > 1 file changed, 156 insertions(+) > > create mode 100644 tools/include/nolibc/arch-powerpc.h > > > > diff --git a/tools/include/nolibc/arch-powerpc.h b/tools/include/nolibc/arch-powerpc.h > > new file mode 100644 > > index 000000000000..100ec0f412dc > > --- /dev/null > > +++ b/tools/include/nolibc/arch-powerpc.h > > @@ -0,0 +1,156 @@ > > +/* SPDX-License-Identifier: LGPL-2.1 OR MIT */ > > +/* > > + * PowerPC specific definitions for NOLIBC > > + * Copyright (C) 2023 Zhangjin Wu <falcon@xxxxxxxxxxx> > > If it is taken from musl, shouldn't there also be a musl copyright? > For this copyright issue, I have prepared two new versions without a line from musl. even in our old version, most of them are different except the 'sc; bns+ 1f; neg %1, %1; 1:' line and the register variables. Seems 'sc; bns+ 1f; neg %1, %1; 1:' is also used in linux kernel: arch/powerpc/include/asm/vdso/gettimeofday.h, so, it should be ok enough to apply it. The register varibles have been changed and aligned with othe arch-<ARCH>.h locally, they are completely different now, and even further with the new syscall.h mentioned in this reply [1], the file will be completely different. Thomas, Have added your Reviewed-by lines too, thanks a lot! Best regards, Zhangjin ---- [1]: https://lore.kernel.org/lkml/20230725054414.15055-1-falcon@xxxxxxxxxxx/
