Re: [PATCH v1 01/11] selftests: forwarding: custom_multipath_hash.sh: add cleanup for SIGTERM sent by timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/23/23 20:54, Mirsad Todorovac wrote:


On 7/23/23 10:25, Ido Schimmel wrote:
On Sat, Jul 22, 2023 at 02:36:00AM +0200, Mirsad Todorovac wrote:
Add trap and cleanup for SIGTERM sent by timeout and SIGINT from
keyboard, for the test times out and leaves incoherent network stack.

Fixes: 511e8db54036c ("selftests: forwarding: Add test for custom multipath hash")
Cc: Ido Schimmel <idosch@xxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
---

The patches are missing your Signed-off-by and a cover letter. Anyway,
please don't send a new version just yet. I'm not sure this is the
correct approach and I'm looking into it.

Thanks

Sure thing. What a blunder, just when I thought I had the perfect patches.

Still, I think it is the way da go for all the test programs, to catch the
SIGINT and SIGTERM ...

This way, I need to reboot the system before running the tests on a clean
slate ...

The tests now did not hang (applied all four patches of yours).

Thank you for your time and work patching.

Some tests however exited with error:

marvin@defiant:~/linux/kernel/linux_torvalds$ grep "not ok" ../kselftest-6.5-rc2-net-forwarding-11.log
not ok 3 selftests: net/forwarding: bridge_mdb.sh # exit=1
not ok 5 selftests: net/forwarding: bridge_mdb_max.sh # exit=1
not ok 11 selftests: net/forwarding: bridge_vlan_mcast.sh # exit=1
not ok 15 selftests: net/forwarding: ethtool_extended_state.sh # exit=1
not ok 17 selftests: net/forwarding: ethtool.sh # exit=1
not ok 25 selftests: net/forwarding: hw_stats_l3_gre.sh # exit=1
not ok 26 selftests: net/forwarding: ip6_forward_instats_vrf.sh # exit=1
not ok 80 selftests: net/forwarding: tc_actions.sh # exit=1
not ok 83 selftests: net/forwarding: tc_flower.sh # exit=1
not ok 84 selftests: net/forwarding: tc_flower_l2_miss.sh # exit=1
not ok 89 selftests: net/forwarding: tc_tunnel_key.sh # exit=1
marvin@defiant:~/linux/kernel/linux_torvalds$

For your convenience, please find the complete test run output attached.

Kind regards,
Mirsad

Attachment: kselftest-6.5-rc2-net-forwarding-11.log.xz
Description: application/xz


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux