Hi On Wed, Jul 19, 2023 at 05:13:50PM +0800, David Gow wrote: > On Wed, 28 Jun 2023 at 17:49, Maxime Ripard <mripard@xxxxxxxxxx> wrote: > > > > Platform devices show some inconsistencies with how devm resources are > > released when the device has been probed and when it hasn't. Let's add a > > few tests to exercise thos paths and odd cases. > > Nit: "these". > > Also, it'd be nice to call out the case that fails explicitly in the > commit message here, so it's obvious what the "inconsistency" is. I've reworded the commit message. > > > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > > --- > > This looks good to me. I think this is, if anything, even more > obviously important than the root device issues, so we definitely need > to fix or document it. > > Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Thanks! Maxime
