Hi Zhangjin, On 2023-07-19 14:49:12+0800, Zhangjin Wu wrote: > > On Wed, Jul 19, 2023 at 07:56:37AM +0800, Zhangjin Wu wrote: > > > It made me recalled I have at last disabled (not enabled for tinyconfig) the following options: > > > > > > CONFIG_ALTIVEC > > > CONFIG_VSX --> This option enables kernel support for the Vector Scaler extensions > > > > > > Or we can disable the vsx instructions explicitly: > > > > > > -mno-vsx > > > > > > Both of them work well, but I prefer -mno-vsx for to get a faster build, what about you? > > > > > > +CFLAGS_powerpc64 = -m64 -mbig-endian -Wl,-EB,-melf64ppc -mno-vsx > > > +CFLAGS_powerpc64le = -m64 -mlittle-endian -Wl,-EL,-melf64ppc -mno-vsx > > > > > > So, this patch itself is wrong, let's drop it from the next revision. > > > > Better explicitly disable it in the CFLAGS (2nd option) if we want to > > make sure we don't want to rely on this, at least for portability > > purposes. > > Ok, thanks, have updated CFLAGS in these two patches locally: > > [PATCH v1 7/8] selftests/nolibc: add test support for powerpc64le > [PATCH v1 8/8] selftests/nolibc: add test support for powerpc64 > > what about the other ones? I'm ready to send v2 ;-) Unfortunately I won't have the time for a proper review this week. Thomas
