On Tue, Jul 18, 2023 at 10:17 AM David Gow <davidgow@xxxxxxxxxx> wrote: > > This is looking good and working well here. > > One super-minor thought below (the generated C file seems to be using > 4-space indentation, not tabs), but it's not something that worries me > enough to hold the patch up if there are no other issues. Good eye! Of course, please feel free to change it when applying (though from a quick grep I don't see "[ ... ]" comments in commits in the KUnit tree). I am also happy to send a v3. Cheers, Miguel