Hi Ilpo, On 7/17/2023 6:05 AM, Ilpo Järvinen wrote: > On Fri, 14 Jul 2023, Reinette Chatre wrote: >> * add check in get_llc_perf() that it does not attempt ioctl() >> on "fd_lm == -1" (later addition would be error checking of >> the ioctl()) > > The other two things suggested seem unnecessary and I've not implemented > them, I don't thinkg fd_lm can be -1 at ioctl(). Given this code is going > to be replaced soonish, putting any extra "safety" effort into it now > seems waste of time. Yes, this suggestion was indeed to make the code more robust. I certainly do not want to waste your time. Please keep in mind when you respond that I do not have insight into the reworks you are still planning. Reinette
