In this series, Geliang did some refactoring in the mptcp_join.sh file. Patch 1 reduces the scope of some global env vars, only used by some tests: easier to deal with. Patch 2 uses a dedicated env var for fastclose case instead of re-using addr_nr_ns2 with embedded info, clearer. Patch 3 is similar but for the fullmesh case. Patch 4 moves a positional but optional argument of run_tests() to an env var like it has already been done with the other args, cleaner. Signed-off-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> --- Geliang Tang (4): selftests: mptcp: set all env vars as local ones selftests: mptcp: add fastclose env var selftests: mptcp: add fullmesh env var selftests: mptcp: add speed env var tools/testing/selftests/net/mptcp/mptcp_join.sh | 271 +++++++++++++----------- 1 file changed, 151 insertions(+), 120 deletions(-) --- base-commit: e0f0a5db5f8c413cbbf48607f711c2a21023ee66 change-id: 20230712-upstream-net-next-20230712-selftests-mptcp-use-local-env-ad964224bc2a Best regards, -- Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>