On Thu, 1 Jun 2023 14:30:05 +0530 Ajay Kaher <akaher@xxxxxxxxxx> wrote: > Introduce tracefs_inode structure, this will help eventfs > to keep track of inode, flags and pointer to private date. > > Rename function names and remove the static qualifier for > functions that should be exposed. We should probably break this patch up into two. Or at least remove the static functions and make them non static whet they are needed. > > Signed-off-by: Ajay Kaher <akaher@xxxxxxxxxx> > Co-developed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> > Tested-by: Ching-lin Yu <chinglinyu@xxxxxxxxxx> > --- > fs/tracefs/inode.c | 21 +++++++++++---------- > fs/tracefs/internal.h | 25 +++++++++++++++++++++++++ > 2 files changed, 36 insertions(+), 10 deletions(-) > create mode 100644 fs/tracefs/internal.h > [..] > diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h > new file mode 100644 > index 000000000..6776b4693 > --- /dev/null > +++ b/fs/tracefs/internal.h > @@ -0,0 +1,25 @@ > +#ifndef _TRACEFS_INTERNAL_H > +#define _TRACEFS_INTERNAL_H > + > +enum { > + TRACEFS_EVENT_INODE = BIT(1), > +}; > + > +struct tracefs_inode { > + unsigned long flags; > + void *private; > + struct inode vfs_inode; > +}; > + > +static inline struct tracefs_inode *get_tracefs(const struct inode > *inode) +{ > + return container_of(inode, struct tracefs_inode, vfs_inode); > +} > + > +struct dentry *tracefs_start_creating(const char *name, struct > dentry *parent); +struct dentry *tracefs_end_creating(struct dentry > *dentry); +struct dentry *tracefs_failed_creating(struct dentry > *dentry); +struct inode *tracefs_get_inode(struct super_block *sb); > + > +#endif /* _TRACEFS_INTERNAL_H */ > + git complains about the above extra line. -- Steve