Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > Florian Westphal <fw@xxxxxxxxx> writes: > As for the original question, that's answered by your point above: If > those two modules are the only ones that are likely to need this, then a > flag for each is fine by me - that was the key piece I was missing (I'm > not a netfilter expert, as you well know). No problem, I was worried I was missing an important piece of kfunc plumbing :-) You do raise a good point though. With kfuncs, module is pinned. So, should a "please turn on defrag for this bpf_link" pin the defrag modules too? For plain netfilter we don't do that, i.e. you can just do "rmmod nf_defrag_ipv4". But I suspect that for the new bpf-link defrag we probably should grab a reference to prevent unwanted functionality breakage of the bpf prog.
