Re: [PATCH] selftests/zram: avoid subshells and bc for ratio calculations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



One minor follow up...

On Wed, 28 Jun 2023 12:53:45 +0200, David Disseldorp wrote:

> Awk is already called for /sys/block/zram#/mm_stat parsing, so use it
> to also perform the floating point capacity vs consumption ratio
> calculations. The test output is unchanged.
> This allows bc to be dropped as a dependency for the zram selftests.

It looks as though the following hunk should also be squashed in. free
usage was dropped with d18da7ec3719559d6e74937266d0416e6c7e0b31:

--- a/tools/testing/selftests/zram/README
+++ b/tools/testing/selftests/zram/README
@@ -27,9 +27,7 @@ zram01.sh: creates general purpose ram disks with ext4 filesystems
 zram02.sh: creates block device for swap
 
 Commands required for testing:
- - bc
  - dd
- - free
  - awk
  - mkswap
  - swapon




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux