On Thu, Jun 22, 2023 at 10:31:06PM +0500, stsp wrote: > > 22.06.2023 22:12, Chuck Lever III пишет: > > I don't have a strong preference. A good choice is to > > push the test before the kernel changes are merged. > It will fail though w/o kernel changes. > So what exactly is the policy? filesystem unit test functionality needs to be pushed into fstests and/or ltp. The preference is the former, because just about every filesystem developer and distro QA team is running this as part of their every-day testing workflow. fstests is written to probe whether the kernel supports a given feature or not before testing it. It will _not_run() a test that doesn't have the required kernel/fs/device support, and this is not considered a test failure. Yes, it means you have to also write the userspace feature probing code, but that should be trivial to do because userspace already has to be able to safely discover that this extension exists, right? -Dave. -- Dave Chinner david@xxxxxxxxxxxxx