Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@xxxxxxxxxx>: On Sat, 10 Jun 2023 18:11:36 +0200 you wrote: > Selftests are supposed to run on any kernels, including the old ones not > supporting all MPTCP features. > > A new function is now available to easily detect if a feature is > missing by looking at the kernel version. That's clearly not ideal and > this kind of check should be avoided as soon as possible. But sometimes, > there are no external sign that a "feature" is available or not: > internal behaviours can change without modifying the uAPI and these > selftests are verifying the internal behaviours. Sometimes, the only > (easy) way to verify if the feature is present is to run the test but > then the validation cannot determine if there is a failure with the > feature or if the feature is missing. Then it looks better to check the > kernel version instead of having tests that can never fail. In any case, > we need a solution not to have a whole selftest being marked as failed > just because one sub-test has failed. > > [...] Here is the summary with links: - [net,01/17] selftests: mptcp: lib: skip if not below kernel version https://git.kernel.org/netdev/net/c/b1a6a38ab8a6 - [net,02/17] selftests: mptcp: join: use 'iptables-legacy' if available https://git.kernel.org/netdev/net/c/0c4cd3f86a40 - [net,03/17] selftests: mptcp: join: helpers to skip tests https://git.kernel.org/netdev/net/c/cdb50525345c - [net,04/17] selftests: mptcp: join: skip check if MIB counter not supported (no matching commit) - [net,05/17] selftests: mptcp: join: skip test if iptables/tc cmds fail https://git.kernel.org/netdev/net/c/4a0b866a3f7d - [net,06/17] selftests: mptcp: join: support local endpoint being tracked or not https://git.kernel.org/netdev/net/c/d4c81bbb8600 - [net,07/17] selftests: mptcp: join: skip Fastclose tests if not supported https://git.kernel.org/netdev/net/c/ae947bb2c253 - [net,08/17] selftests: mptcp: join: support RM_ADDR for used endpoints or not https://git.kernel.org/netdev/net/c/425ba803124b - [net,09/17] selftests: mptcp: join: skip implicit tests if not supported https://git.kernel.org/netdev/net/c/36c4127ae8dd - [net,10/17] selftests: mptcp: join: skip backup if set flag on ID not supported https://git.kernel.org/netdev/net/c/07216a3c5d92 - [net,11/17] selftests: mptcp: join: skip fullmesh flag tests if not supported https://git.kernel.org/netdev/net/c/9db34c4294af - [net,12/17] selftests: mptcp: join: skip userspace PM tests if not supported https://git.kernel.org/netdev/net/c/f2b492b04a16 - [net,13/17] selftests: mptcp: join: skip fail tests if not supported https://git.kernel.org/netdev/net/c/ff8897b51894 - [net,14/17] selftests: mptcp: join: skip MPC backups tests if not supported https://git.kernel.org/netdev/net/c/632978f0a961 - [net,15/17] selftests: mptcp: join: skip PM listener tests if not supported https://git.kernel.org/netdev/net/c/0471bb479af0 - [net,16/17] selftests: mptcp: join: uniform listener tests https://git.kernel.org/netdev/net/c/96b84195df61 - [net,17/17] selftests: mptcp: join: skip mixed tests if not supported https://git.kernel.org/netdev/net/c/6673851be0fc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html