Re: [PATCH bpf v4 2/2] selftests/bpf: Add test cases to assert proper ID tracking on spill

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Maxim Mikityanskiy <maxtram95@xxxxxxxxx>, bpf@xxxxxxxxxxxxxxx
Subject: Re: [PATCH bpf v4 2/2] selftests/bpf: Add test cases to assert proper ID tracking on spill
From: Yonghong Song <yhs@xxxxxxxx>
Date: Wed, 7 Jun 2023 08:35:23 -0700
Cc: netdev@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Maxim Mikityanskiy <maxim@xxxxxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yhs@xxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>
In-reply-to: <20230607123951.558971-3-maxtram95@gmail.com>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2



On 6/7/23 5:39 AM, Maxim Mikityanskiy wrote:

From: Maxim Mikityanskiy <maxim@xxxxxxxxxxxxx>

The previous commit fixed a verifier bypass by ensuring that ID is not
preserved on narrowing spills. Add the test cases to check the
problematic patterns.

Signed-off-by: Maxim Mikityanskiy <maxim@xxxxxxxxxxxxx>


Acked-by: Yonghong Song <yhs@xxxxxx>

References:
- [PATCH bpf v4 0/2] Fix verifier id tracking of scalars on spill
  - From: Maxim Mikityanskiy
- [PATCH bpf v4 2/2] selftests/bpf: Add test cases to assert proper ID tracking on spill
  - From: Maxim Mikityanskiy

Prev by Date: [PATCH v3] selftests/input: Introduce basic tests for evdev ioctls
Next by Date: [PATCH v2] selftests: prctl: Add new prctl test for PR_SET_NAME
Previous by thread: [PATCH bpf v4 2/2] selftests/bpf: Add test cases to assert proper ID tracking on spill
Next by thread: Re: [PATCH bpf v4 0/2] Fix verifier id tracking of scalars on spill
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]