Hi Dave, Thanks for feedback, regarding sigaltstack: On Thu, May 18, 2023 at 2:04 PM Dave Hansen <dave.hansen@xxxxxxxxx> wrote: > > > > Agreed on signaling handling is a tough part: what do you think about > > the approach (modifying PKRU from saved stack after XSAVE), is there a > > blocker ? > > Yes, signal entry and sigreturn are not necessarily symmetric so you > can't really have a stack. > To clarify: I mean this option below: - before get_sigframe(), save PKUR => tmp - modify thread's PKRU so it can write to sigframe - XSAVE - save tmp => sigframe I believe you proposed this in a previous discussion [1]: and I quote here: "There's a delicate point when building the stack frame that the kernel would need to move over to the new PKRU value to build the frame before it writes the *OLD* value to the frame. But, it's far from impossible." sigreturn will restore thread's original PKRU from sigframe. In case of asymmetrics caused by siglongjmp, user space doesn't call sigreturn, the application needs to set desired PKRU before siglongjmp. I think this solution should work. [1] https://lore.kernel.org/lkml/b4f0dca5-1d15-67f7-4600-9a0a91e9d0bd@xxxxxxxxx/ Best regards, -Jeff
