On 5/29/23 2:19 PM, Benjamin Poirier wrote:
> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index f95142e56da0..27089dea0ed0 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c
> @@ -1152,11 +1152,31 @@ static bool ipv4_good_nh(const struct fib_nh *nh)
> return !!(state & NUD_VALID);
> }
>
> +static struct nexthop *nexthop_select_path_fdb(struct nh_group *nhg, int hash)
> +{
> + int i;
> +
> + for (i = 0; i < nhg->num_nh; i++) {
> + struct nh_grp_entry *nhge = &nhg->nh_entries[i];
> +
> + if (hash > atomic_read(&nhge->hthr.upper_bound))
> + continue;
> +
> + return nhge->nh;
> + }
> +
> + WARN_ON_ONCE(1);
I do not see how the stack is going to provide useful information; it
should always be vxlan_xmit ... nexthop_select_path_fdb, right?
besides that:
Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>
