On Tue, Apr 11, 2023 at 7:15 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > From: Mirsad Todorovac <mirsad.todorovac@xxxxxxxxxxxx> > > According to Mirsad the gpio-sim.sh test appears to FAIL in a wrong way > due to missing initialisation of shell variables: > > 4.2. Bias settings work correctly > cat: /sys/devices/platform/gpio-sim.0/gpiochip18/sim_gpio0/value: No such file or directory > ./gpio-sim.sh: line 393: test: =: unary operator expected > bias setting does not work > GPIO gpio-sim test FAIL > > After this change the test passed: > > 4.2. Bias settings work correctly > GPIO gpio-sim test PASS > > His testing environment is AlmaLinux 8.7 on Lenovo desktop box with > the latest Linux kernel based on v6.2: > > Linux 6.2.0-mglru-kmlk-andy-09238-gd2980d8d8265 x86_64 > > Suggested-by: Mirsad Todorovac <mirsad.todorovac@xxxxxxxxxxxx> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > tools/testing/selftests/gpio/gpio-sim.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh > index 9f539d454ee4..fa2ce2b9dd5f 100755 > --- a/tools/testing/selftests/gpio/gpio-sim.sh > +++ b/tools/testing/selftests/gpio/gpio-sim.sh > @@ -389,6 +389,9 @@ create_chip chip > create_bank chip bank > set_num_lines chip bank 8 > enable_chip chip > +DEVNAME=`configfs_dev_name chip` > +CHIPNAME=`configfs_chip_name chip bank` > +SYSFS_PATH="/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio0/value" > $BASE_DIR/gpio-mockup-cdev -b pull-up /dev/`configfs_chip_name chip bank` 0 > test `cat $SYSFS_PATH` = "1" || fail "bias setting does not work" > remove_chip chip > -- > 2.40.0.1.gaa8946217a0b > Queued for fixes. Thanks! Bart
