Re: [PATCH] kselftest: vDSO: Fix accumulation of uninitialized ret when CLOCK_REALTIME is undefined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/18/23 04:14, Colin King (gmail) wrote:
On 18/04/2023 11:10, Vincenzo Frascino wrote:
Hi Colin,

On 4/17/23 11:47, Colin Ian King wrote:
In the unlikely case that CLOCK_REALTIME is not defined, variable ret is
not initialized and further accumulation of return values to ret can leave
ret in an undefined state. Fix this by initialized ret to zero and changing
the assignment of ret to an accumulation for the CLOCK_REALTIME case.


I was wondering how did you find this.

I used cppcheck --force --enable=all, this examines the #if defined() paths.


Apart that:

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>


Applied to linux-kselftest next

thanks,
-- Shuah




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux