On Tue, 25 Apr 2023 at 23:23, Maxime Ripard <maxime@xxxxxxxxxx> wrote: > > Hi, > > On Fri, Apr 21, 2023 at 04:42:23PM +0800, David Gow wrote: > > This is v1 of the KUnit deferred actions API, which implements an > > equivalent of devm_add_action[1] on top of KUnit managed resources. This > > provides a simple way of scheduling a function to run when the test > > terminates (whether successfully, or with an error). It's therefore very > > useful for freeing resources, or otherwise cleaning up. > > > > The notable changes since RFCv2[2] are: > > - Got rid of the 'cancellation token' concept. It was overcomplicated, > > and we can add it back if we need to. > > - kunit_add_action() therefore now returns 0 on success, and an error > > otherwise (like devm_add_action()). Though you may wish to use: > > - Added kunit_add_action_or_reset(), which will call the deferred > > function if an error occurs. (See devm_add_action_or_reset()). This > > also returns an error on failure, which can be asserted safely. > > - Got rid of the function pointer typedef. Personally, I liked it, but > > it's more typedef-y than most kernel code. > > - Got rid of the 'internal_gfp' argument: all internal state is now > > allocated with GFP_KERNEL. The main KUnit resource API can be used > > instead if this doesn't work for your use-case. > > > > I'd love to hear any further thoughts! > > I've converted the KMS kunit tests to use that API when relevant, and > it works like a charm and is super usable, thanks so much. Nice! I'm glad it's working well. > > One improvement we could do as a second step is to provide a > kunit_action_t type or something to make casting kfree-like functions > easier, but it's already great overall. I had that in an earlier version and got rid of it to better match what devm_* was doing, but I personally agree that it's nice to have. I'll add it back in the next version. > Reviewed-by: Maxime Ripard <maxime@xxxxxxxxxx> > Tested-by: Maxime Ripard <maxime@xxxxxxxxxx> Cheers, -- David
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
