Hi Ilpo, On 4/18/2023 4:44 AM, Ilpo Järvinen wrote: > fill_buf(), show_bw_info(), and resctrl_val_param.span define span as > unsigned long. There is no fill_buf() in the code and show_bw_info() does not define span as unsigned long (it is even the first function changed in this patch). > > Consistently use unsigned long elsewhere too for span parameters. Is unsigned long the right type to use? Tracing through all the indirections I do not see how making all usages unsigned long achieves consistency ... have you considered size_t? Reinette