Hi Muhammad, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [cannot apply to linus/master v6.3-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230417-210005 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230417125630.1146906-3-usama.anjum%40collabora.com patch subject: [PATCH v13 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs config: i386-randconfig-a003-20230417 (https://download.01.org/0day-ci/archive/20230418/202304180050.anuTGBfy-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/2e7e6f5bd3b9c28493f9871282fe8f14e2263962 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230417-210005 git checkout 2e7e6f5bd3b9c28493f9871282fe8f14e2263962 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202304180050.anuTGBfy-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): fs/proc/task_mmu.c: In function 'pagemap_scan_pte_hole': >> fs/proc/task_mmu.c:2059:14: error: invalid use of undefined type 'struct pagemap_scan_private' 2059 | if (p->max_pages && p->found_pages + n_pages > p->max_pages) | ^~ fs/proc/task_mmu.c:2059:30: error: invalid use of undefined type 'struct pagemap_scan_private' 2059 | if (p->max_pages && p->found_pages + n_pages > p->max_pages) | ^~ fs/proc/task_mmu.c:2059:57: error: invalid use of undefined type 'struct pagemap_scan_private' 2059 | if (p->max_pages && p->found_pages + n_pages > p->max_pages) | ^~ fs/proc/task_mmu.c:2060:28: error: invalid use of undefined type 'struct pagemap_scan_private' 2060 | n_pages = p->max_pages - p->found_pages; | ^~ fs/proc/task_mmu.c:2060:43: error: invalid use of undefined type 'struct pagemap_scan_private' 2060 | n_pages = p->max_pages - p->found_pages; | ^~ >> fs/proc/task_mmu.c:2062:15: error: implicit declaration of function 'pagemap_scan_output' [-Werror=implicit-function-declaration] 2062 | ret = pagemap_scan_output(false, vma->vm_file, false, false, p, addr, | ^~~~~~~~~~~~~~~~~~~ fs/proc/task_mmu.c: At top level: >> fs/proc/task_mmu.c:2068:22: error: 'pagemap_scan_test_walk' undeclared here (not in a function); did you mean 'pagemap_scan_pte_hole'? 2068 | .test_walk = pagemap_scan_test_walk, | ^~~~~~~~~~~~~~~~~~~~~~ | pagemap_scan_pte_hole >> fs/proc/task_mmu.c:2069:22: error: 'pagemap_scan_pmd_entry' undeclared here (not in a function); did you mean 'pagemap_scan_pte_hole'? 2069 | .pmd_entry = pagemap_scan_pmd_entry, | ^~~~~~~~~~~~~~~~~~~~~~ | pagemap_scan_pte_hole fs/proc/task_mmu.c: In function 'pagemap_scan_args_valid': >> fs/proc/task_mmu.c:2080:27: error: 'PM_SCAN_OPS' undeclared (first use in this function); did you mean 'PM_SCAN_OP_WP'? 2080 | if (arg->flags & ~PM_SCAN_OPS) | ^~~~~~~~~~~ | PM_SCAN_OP_WP fs/proc/task_mmu.c:2080:27: note: each undeclared identifier is reported only once for each function it appears in >> fs/proc/task_mmu.c:2085:35: error: 'PM_SCAN_BITS_ALL' undeclared (first use in this function); did you mean 'CPU_BITS_ALL'? 2085 | arg->return_mask) & ~PM_SCAN_BITS_ALL) | ^~~~~~~~~~~~~~~~ | CPU_BITS_ALL >> fs/proc/task_mmu.c:2106:14: error: implicit declaration of function 'PM_SCAN_DO_UFFD_WP'; did you mean 'PM_SCAN_OP_WP'? [-Werror=implicit-function-declaration] 2106 | if (!PM_SCAN_DO_UFFD_WP(arg)) | ^~~~~~~~~~~~~~~~~~ | PM_SCAN_OP_WP fs/proc/task_mmu.c: In function 'do_pagemap_scan': >> fs/proc/task_mmu.c:2123:37: error: storage size of 'p' isn't known 2123 | struct pagemap_scan_private p; | ^ >> fs/proc/task_mmu.c:2148:21: error: 'PAGEMAP_WALK_SIZE' undeclared (first use in this function); did you mean 'PAGE_TABLE_SIZE'? 2148 | p.vec_len = PAGEMAP_WALK_SIZE >> PAGE_SHIFT; | ^~~~~~~~~~~~~~~~~ | PAGE_TABLE_SIZE In file included from include/linux/kernel.h:27, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/preempt.h:6, from include/linux/preempt.h:78, from include/linux/spinlock.h:56, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/mm.h:7, from include/linux/pagewalk.h:5, from fs/proc/task_mmu.c:2: >> include/linux/minmax.h:36:9: error: first argument to '__builtin_choose_expr' not a constant 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~~~~~~~~~~~~ include/linux/minmax.h:67:25: note: in expansion of macro '__careful_cmp' 67 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ fs/proc/task_mmu.c:2173:29: note: in expansion of macro 'min' 2173 | p.vec_len = min(p.vec_len, empty_slots); | ^~~ >> fs/proc/task_mmu.c:2175:63: error: 'PAGEMAP_WALK_MASK' undeclared (first use in this function) 2175 | walk_end = (walk_start + PAGEMAP_WALK_SIZE) & PAGEMAP_WALK_MASK; | ^~~~~~~~~~~~~~~~~ >> fs/proc/task_mmu.c:2186:53: error: 'PM_SCAN_FOUND_MAX_PAGES' undeclared (first use in this function) 2186 | if (ret && ret != -ENOSPC && ret != PM_SCAN_FOUND_MAX_PAGES) | ^~~~~~~~~~~~~~~~~~~~~~~ fs/proc/task_mmu.c:2123:37: warning: unused variable 'p' [-Wunused-variable] 2123 | struct pagemap_scan_private p; | ^ fs/proc/task_mmu.c: At top level: >> fs/proc/task_mmu.c:2240:27: error: 'pagemap_read' undeclared here (not in a function); did you mean 'filemap_read'? 2240 | .read = pagemap_read, | ^~~~~~~~~~~~ | filemap_read >> fs/proc/task_mmu.c:2241:27: error: 'pagemap_open' undeclared here (not in a function); did you mean 'pid_maps_open'? 2241 | .open = pagemap_open, | ^~~~~~~~~~~~ | pid_maps_open >> fs/proc/task_mmu.c:2242:27: error: 'pagemap_release' undeclared here (not in a function); did you mean 'proc_map_release'? 2242 | .release = pagemap_release, | ^~~~~~~~~~~~~~~ | proc_map_release fs/proc/task_mmu.c:2246:2: error: #endif without #if 2246 | #endif /* CONFIG_PROC_PAGE_MONITOR */ | ^~~~~ cc1: some warnings being treated as errors vim +2059 fs/proc/task_mmu.c 2047 2048 static int pagemap_scan_pte_hole(unsigned long addr, unsigned long end, 2049 int depth, struct mm_walk *walk) 2050 { 2051 unsigned long n_pages = (end - addr)/PAGE_SIZE; 2052 struct pagemap_scan_private *p = walk->private; 2053 struct vm_area_struct *vma = walk->vma; 2054 int ret = 0; 2055 2056 if (!vma) 2057 return 0; 2058 > 2059 if (p->max_pages && p->found_pages + n_pages > p->max_pages) > 2060 n_pages = p->max_pages - p->found_pages; 2061 > 2062 ret = pagemap_scan_output(false, vma->vm_file, false, false, p, addr, 2063 n_pages); 2064 return ret; 2065 } 2066 2067 static const struct mm_walk_ops pagemap_scan_ops = { > 2068 .test_walk = pagemap_scan_test_walk, > 2069 .pmd_entry = pagemap_scan_pmd_entry, 2070 .pte_hole = pagemap_scan_pte_hole, 2071 .hugetlb_entry = pagemap_scan_hugetlb_entry, 2072 }; 2073 2074 static int pagemap_scan_args_valid(struct pm_scan_arg *arg, unsigned long start, 2075 struct page_region __user *vec) 2076 { 2077 /* Detect illegal size, flags, len and masks */ 2078 if (arg->size != sizeof(struct pm_scan_arg)) 2079 return -EINVAL; > 2080 if (arg->flags & ~PM_SCAN_OPS) 2081 return -EINVAL; 2082 if (!arg->len) 2083 return -EINVAL; 2084 if ((arg->required_mask | arg->anyof_mask | arg->excluded_mask | > 2085 arg->return_mask) & ~PM_SCAN_BITS_ALL) 2086 return -EINVAL; 2087 if (!arg->required_mask && !arg->anyof_mask && 2088 !arg->excluded_mask) 2089 return -EINVAL; 2090 if (!arg->return_mask) 2091 return -EINVAL; 2092 2093 /* Validate memory ranges */ 2094 if (!(arg->flags & PM_SCAN_OP_GET)) 2095 return -EINVAL; 2096 if (!arg->vec) 2097 return -EINVAL; 2098 if (arg->vec_len == 0) 2099 return -EINVAL; 2100 2101 if (!IS_ALIGNED(start, PAGE_SIZE)) 2102 return -EINVAL; 2103 if (!access_ok((void __user *)start, arg->len)) 2104 return -EFAULT; 2105 > 2106 if (!PM_SCAN_DO_UFFD_WP(arg)) 2107 return 0; 2108 2109 if ((arg->required_mask | arg->anyof_mask | arg->excluded_mask) & 2110 ~PAGE_IS_WRITTEN) 2111 return -EINVAL; 2112 2113 return 0; 2114 } 2115 2116 static long do_pagemap_scan(struct mm_struct *mm, 2117 struct pm_scan_arg __user *uarg) 2118 { 2119 unsigned long start, end, walk_start, walk_end; 2120 unsigned long empty_slots, vec_index = 0; 2121 struct mmu_notifier_range range; 2122 struct page_region __user *vec; > 2123 struct pagemap_scan_private p; 2124 struct pm_scan_arg arg; 2125 int ret = 0; 2126 2127 if (copy_from_user(&arg, uarg, sizeof(arg))) 2128 return -EFAULT; 2129 2130 start = untagged_addr((unsigned long)arg.start); 2131 vec = (struct page_region *)untagged_addr((unsigned long)arg.vec); 2132 2133 ret = pagemap_scan_args_valid(&arg, start, vec); 2134 if (ret) 2135 return ret; 2136 2137 end = start + arg.len; 2138 p.max_pages = arg.max_pages; 2139 p.found_pages = 0; 2140 p.flags = arg.flags; 2141 p.required_mask = arg.required_mask; 2142 p.anyof_mask = arg.anyof_mask; 2143 p.excluded_mask = arg.excluded_mask; 2144 p.return_mask = arg.return_mask; 2145 p.cur.len = 0; 2146 p.cur.start = 0; 2147 p.vec = NULL; > 2148 p.vec_len = PAGEMAP_WALK_SIZE >> PAGE_SHIFT; 2149 2150 /* 2151 * Allocate smaller buffer to get output from inside the page walk 2152 * functions and walk page range in PAGEMAP_WALK_SIZE size chunks. As 2153 * we want to return output to user in compact form where no two 2154 * consecutive regions should be continuous and have the same flags. 2155 * So store the latest element in p.cur between different walks and 2156 * store the p.cur at the end of the walk to the user buffer. 2157 */ 2158 p.vec = kmalloc_array(p.vec_len, sizeof(*p.vec), GFP_KERNEL); 2159 if (!p.vec) 2160 return -ENOMEM; 2161 2162 if (p.flags & PM_SCAN_OP_WP) { 2163 mmu_notifier_range_init(&range, MMU_NOTIFY_PROTECTION_VMA, 0, 2164 vma->vm_mm, start, end); 2165 mmu_notifier_invalidate_range_start(&range); 2166 } 2167 2168 walk_start = walk_end = start; 2169 while (walk_end < end && !ret) { 2170 p.vec_index = 0; 2171 2172 empty_slots = arg.vec_len - vec_index; > 2173 p.vec_len = min(p.vec_len, empty_slots); 2174 > 2175 walk_end = (walk_start + PAGEMAP_WALK_SIZE) & PAGEMAP_WALK_MASK; 2176 if (walk_end > end) 2177 walk_end = end; 2178 2179 ret = mmap_read_lock_killable(mm); 2180 if (ret) 2181 goto free_data; 2182 ret = walk_page_range(mm, walk_start, walk_end, 2183 &pagemap_scan_ops, &p); 2184 mmap_read_unlock(mm); 2185 > 2186 if (ret && ret != -ENOSPC && ret != PM_SCAN_FOUND_MAX_PAGES) 2187 goto free_data; 2188 2189 walk_start = walk_end; 2190 if (p.vec_index) { 2191 if (copy_to_user(&vec[vec_index], p.vec, 2192 p.vec_index * sizeof(*p.vec))) { 2193 /* 2194 * Return error even though the OP succeeded 2195 */ 2196 ret = -EFAULT; 2197 goto free_data; 2198 } 2199 vec_index += p.vec_index; 2200 } 2201 } 2202 2203 if (p.flags & PM_SCAN_OP_WP) { 2204 mmu_notifier_invalidate_range_end(&range); 2205 flush_tlb_mm_range(mm, start, end, PAGE_SHIFT, false); 2206 } 2207 2208 if (p.cur.len) { 2209 if (copy_to_user(&vec[vec_index], &p.cur, sizeof(*p.vec))) { 2210 ret = -EFAULT; 2211 goto free_data; 2212 } 2213 vec_index++; 2214 } 2215 2216 ret = vec_index; 2217 2218 free_data: 2219 kfree(p.vec); 2220 return ret; 2221 } 2222 2223 static long do_pagemap_cmd(struct file *file, unsigned int cmd, 2224 unsigned long arg) 2225 { 2226 struct pm_scan_arg __user *uarg = (struct pm_scan_arg __user *)arg; 2227 struct mm_struct *mm = file->private_data; 2228 2229 switch (cmd) { 2230 case PAGEMAP_SCAN: 2231 return do_pagemap_scan(mm, uarg); 2232 2233 default: 2234 return -EINVAL; 2235 } 2236 } 2237 2238 const struct file_operations proc_pagemap_operations = { 2239 .llseek = mem_lseek, /* borrow this */ > 2240 .read = pagemap_read, > 2241 .open = pagemap_open, > 2242 .release = pagemap_release, 2243 .unlocked_ioctl = do_pagemap_cmd, 2244 .compat_ioctl = do_pagemap_cmd, 2245 }; 2246 #endif /* CONFIG_PROC_PAGE_MONITOR */ 2247 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
