Re: [BUG] [PATCH RFC v2] selftests/firmware: copious kernel memory leaks in test_fw_run_batch_request()

[Takashi Iwai <tiwai@xxxxxxx>]

On Thu, 30 Mar 2023 17:44:42 +0200,
Dan Carpenter wrote:
> 
> I admire your enthusiam.  :)  What about if we just did this?  Does it
> help with the leaks?
> 
> regards,
> dan carpenter
> 
> diff --git a/lib/test_firmware.c b/lib/test_firmware.c
> index 05ed84c2fc4c..626b836895f4 100644
> --- a/lib/test_firmware.c
> +++ b/lib/test_firmware.c
> @@ -895,6 +895,9 @@ static ssize_t trigger_batched_requests_store(struct device *dev,
>  
>  	mutex_lock(&test_fw_mutex);
>  
> +	if (test_fw_config->reqs)
> +		return -EBUSY;
> +

This leaves the mutex locked.
It should be the following instead, I suppose?

	if (test_fw_config->reqs) {
		rc = -EBUSY;
		goto out_unlock;
	}


Takashi