Re: [PATCH] kselftest/alsa: Fix -Wformat compiler warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 Mar 2023 10:43:38 +0100,
Takashi Iwai wrote:
> 
> On Fri, 24 Mar 2023 10:28:06 +0100,
> Alexander Heinrich wrote:
> > 
> > I noticed some -Wformat compiler warnings in pcm-test.c while building
> > kselftest, fix them by using the same types for format specifier and arguments.
> > 
> > Signed-off-by: Alexander Heinrich <hallo@xxxxxxxxxxxxxxxxxxxx>
> 
> Those variables (rates, channels, etc) should be rather int instead of
> long, as these are not 64bit parameters on 32bit archs.
> On top of that, the whole '%l' prefix and cast should be dropped.
> 
> The only concern is the string to int conversion, and this should be
> checked carefully, but other than that, it must be straightforward.
> 
> Care to work on that way?

... and the code has been already changed meanwhile.  Please work on
for-next branch of my sound.git tree.


thanks,

Takashi



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux