On Mon, Mar 20, 2023 at 12:28:05PM -0700, Boqun Feng wrote: > On Mon, Mar 20, 2023 at 12:09:00PM -0700, Paul E. McKenney wrote: > > On Mon, Mar 20, 2023 at 11:19:05AM -0700, Boqun Feng wrote: > > > Hi Paul, > > > > > > On Thu, Mar 16, 2023 at 08:13:39PM -0700, Boqun Feng wrote: > > > > From: "Paul E. McKenney" <paulmck@xxxxxxxxxx> > > > > > > > > This commit adds an srcu_lockdep.sh script that checks whether lockdep > > > > correctly classifies SRCU-based, SRCU/mutex-based, and SRCU/rwsem-based > > > > deadlocks. > > > > > > > > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx> > > > > [ boqun: Fix "RCUTORTURE" with "$RCUTORTURE" ] > > > > Signed-off-by: Boqun Feng <boqun.feng@xxxxxxxxx> > > > > --- > > > > .../selftests/rcutorture/bin/srcu_lockdep.sh | 73 +++++++++++++++++++ > > > > 1 file changed, 73 insertions(+) > > > > create mode 100755 tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh b/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh > > > > new file mode 100755 > > > > index 000000000000..961932754684 > > > > --- /dev/null > > > > +++ b/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh > > > > > > Could you provide the SPDX header and copyright bits for this newly > > > added file? For small changes I can do it myself, however this is about > > > licenses and copyright, so I need it from you, thanks! > > > > Good catch, thank you! > > > > Would you like a delta patch to merge into your existing one, or would > > you prefer a replacement patch? Either way works for me. > > > > A delta patch if that's not much trouble. I will fold it into this one. Here you go! Thanx, Paul ------------------------------------------------------------------------ rcutorture: Add proper comment header to srcu_lockdep.sh This patch adds a proper comment header to srcu_lockdep.sh, and is intended to be folded into 9dc68f40c665 ("rcutorture: Add srcu_lockdep.sh"). Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx> diff --git a/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh b/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh index 961932754684..2e63ef009d59 100755 --- a/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh +++ b/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh @@ -1,6 +1,11 @@ #!/bin/bash +# SPDX-License-Identifier: GPL-2.0+ # # Run SRCU-lockdep tests and report any that fail to meet expectations. +# +# Copyright (C) 2021 Meta Platforms, Inc. +# +# Authors: Paul E. McKenney <paulmck@xxxxxxxxxx> usage () { echo "Usage: $scriptname optional arguments:"