On Wed, 2023-03-15 at 23:02 -0700, Daniel Latypov wrote: > On Wed, Mar 15, 2023 at 10:57 PM Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > This should be IO[str], since we use it for printing strings. > > This is a good catch, thanks. > But we also have a few more bare generic types that warrant attention. Oh, that might well be true. I was using kunit_parser in a script, and that imports kunit_printer, and then tried to check *my* script for type annotations with mypy. This led it to go check through the dependencies too, and since it was just one small thing there I decided to just fix it rather than figure out how to tell mypy that I don't care about those dependencies :-) Now for everything else? I didn't even look. > I think the diff below [1] should fix the others as well. > I can send it out as a formal patch and add your name for the Reported-by? Sure! johannes
