Hi Ilpo, On 2/15/2023 5:05 AM, Ilpo Järvinen wrote: > resctrl_val() function is called only by MBM, MBA, and CMT tests which Surely not a reason for a resubmit, but just fyi ... using "()" implies that it is a function so there is no need to add the text "function". > means the else branch is never used. > > Both test branches call param->setup(). > > Remove the unused else branch and place the ->setup() call outside of > the test specific branches reducing code duplication. > > Co-developed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- Thank you Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> Reinette
