Re: [PATCH] selftests/ftrace: Update comment and clean up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 15 Mar 2023 13:09:51 +0900
Paran Lee <p4ranlee@xxxxxxxxx> wrote:

> The first thing I noticed was that the a comment where "_do_fork was
> changed to kernel_fork" instead of "kernel_clone",
> so I fixed that as well.
> 
> Would it be better to send that typo fix along with the other fixes?

Yes. And I'm glad I didn't ack this patch. A patch changing formatting
should *never* include any other changes. No typo fixes or what not. It
makes it impossible to review what exactly changed.

One reason I hate format changes is that they can sneak other changes in
undetected.

-- Steve



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux