Wed, Mar 08, 2023 at 11:21:57AM CET, po-hsu.lin@xxxxxxxxxxxxx wrote:
>On Wed, Mar 8, 2023 at 5:31 PM Jiri Pirko <jiri@xxxxxxxxxxx> wrote:
>>
>> Tue, Mar 07, 2023 at 04:00:30PM CET, po-hsu.lin@xxxxxxxxxxxxx wrote:
>> >The `devlink -j port show` command output may not contain the "flavour"
>> >key, an example from s390x LPAR with Ubuntu 22.10 (5.19.0-37-generic),
>> >iproute2-5.15.0:
>> > {"port":{"pci/0001:00:00.0/1":{"type":"eth","netdev":"ens301"},
>> > "pci/0001:00:00.0/2":{"type":"eth","netdev":"ens301d1"},
>> > "pci/0002:00:00.0/1":{"type":"eth","netdev":"ens317"},
>> > "pci/0002:00:00.0/2":{"type":"eth","netdev":"ens317d1"}}}
>>
>> As Jakub wrote, this is odd. Could you debug if kernel sends the flavour
>> attr and if not why? Also, could you try with most recent kernel?
>
>I did a quick check on another s390x LPAR instance which is running
>with Ubuntu 23.04 (6.1.0-16-generic) iproute2-6.1.0, there is still no
>"flavour" attribute.
>$ devlink port show
>pci/0001:00:00.0/1: type eth netdev ens301
>pci/0001:00:00.0/2: type eth netdev ens301d1
>pci/0002:00:00.0/1: type eth netdev ens317
>pci/0002:00:00.0/2: type eth netdev ens317d1
>
>The behaviour didn't change with iproute2 built from source [1]
Could you paste output of "devlink dev info"?
Looks like something might be wrong in the kernel devlink/driver code.
