Hi Rae, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 766f4f2514d2d18bcbd60a058188fb502dea5ddf] url: https://github.com/intel-lab-lkp/linux/commits/Rae-Moar/kunit-fix-bug-in-debugfs-logs-of-parameterized-tests/20230201-060537 base: 766f4f2514d2d18bcbd60a058188fb502dea5ddf patch link: https://lore.kernel.org/r/20230131220355.1603527-2-rmoar%40google.com patch subject: [PATCH v1 1/3] kunit: fix bug in debugfs logs of parameterized tests config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230201/202302010709.7ZmEen4w-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/c8b669e1d139e1ee08121b184d859e45d7a02940 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Rae-Moar/kunit-fix-bug-in-debugfs-logs-of-parameterized-tests/20230201-060537 git checkout c8b669e1d139e1ee08121b184d859e45d7a02940 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash lib/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): lib/kunit/test.c: In function '__kunit_fail_current_test_impl': lib/kunit/test.c:40:9: warning: function '__kunit_fail_current_test_impl' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 40 | len = vsnprintf(NULL, 0, fmt, args) + 1; | ^~~ lib/kunit/test.c:48:9: warning: function '__kunit_fail_current_test_impl' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format] 48 | vsnprintf(buffer, len, fmt, args); | ^~~~~~~~~ lib/kunit/test.c: In function 'kunit_log_append': >> lib/kunit/test.c:133:1: warning: the frame size of 1500 bytes is larger than 1024 bytes [-Wframe-larger-than=] 133 | } | ^ vim +133 lib/kunit/test.c acd8e8407b8fcc David Gow 2021-08-03 110 e2219db280e3fe Alan Maguire 2020-03-26 111 /* e2219db280e3fe Alan Maguire 2020-03-26 112 * Append formatted message to log, size of which is limited to e2219db280e3fe Alan Maguire 2020-03-26 113 * KUNIT_LOG_SIZE bytes (including null terminating byte). e2219db280e3fe Alan Maguire 2020-03-26 114 */ e2219db280e3fe Alan Maguire 2020-03-26 115 void kunit_log_append(char *log, const char *fmt, ...) e2219db280e3fe Alan Maguire 2020-03-26 116 { e2219db280e3fe Alan Maguire 2020-03-26 117 char line[KUNIT_LOG_SIZE]; e2219db280e3fe Alan Maguire 2020-03-26 118 va_list args; e2219db280e3fe Alan Maguire 2020-03-26 119 int len_left; e2219db280e3fe Alan Maguire 2020-03-26 120 e2219db280e3fe Alan Maguire 2020-03-26 121 if (!log) e2219db280e3fe Alan Maguire 2020-03-26 122 return; e2219db280e3fe Alan Maguire 2020-03-26 123 e2219db280e3fe Alan Maguire 2020-03-26 124 len_left = KUNIT_LOG_SIZE - strlen(log) - 1; e2219db280e3fe Alan Maguire 2020-03-26 125 if (len_left <= 0) e2219db280e3fe Alan Maguire 2020-03-26 126 return; e2219db280e3fe Alan Maguire 2020-03-26 127 e2219db280e3fe Alan Maguire 2020-03-26 128 va_start(args, fmt); e2219db280e3fe Alan Maguire 2020-03-26 129 vsnprintf(line, sizeof(line), fmt, args); e2219db280e3fe Alan Maguire 2020-03-26 130 va_end(args); e2219db280e3fe Alan Maguire 2020-03-26 131 e2219db280e3fe Alan Maguire 2020-03-26 132 strncat(log, line, len_left); e2219db280e3fe Alan Maguire 2020-03-26 @133 } e2219db280e3fe Alan Maguire 2020-03-26 134 EXPORT_SYMBOL_GPL(kunit_log_append); e2219db280e3fe Alan Maguire 2020-03-26 135 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
